[PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

Thomas Zimmermann tzimmermann at suse.de
Thu Feb 18 08:18:22 UTC 2021


Hi

Am 17.02.21 um 17:21 schrieb Vitaly Kuznetsov:
> Deepak Rawat <drawat.floss at gmail.com> writes:
> 
>> On Wed, 2021-02-17 at 13:07 +0100, Vitaly Kuznetsov wrote:
>>>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm.h
>>>> @@ -0,0 +1,51 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>> +/*
>>>> + * Copyright 2012-2021 Microsoft
>>>
>>> Out of pure curiosity, where does '2012' come from or what does it
>>> mean?
>>>
>>
>> Thanks Vitaly for the review. Actually some of the code is derived from
>> hyperv_fb, which has copyright 2012. Not sure if I should remove here
>> or not?
>>
> 
> I'm definitely not an expert (and couldn't quickly find a good
> reference) here but I was under the impression that in such cases you
> can just add a note like "based on 'hyperv_fb' driver" (if really
> needed, if you just borrow a few things then it's even superfluous I
> believe). Anyway, I was just a bit surprised to see '2012' in a new file
> :-)

As suggested, I'd just leave a note that it's based on hyperv_fb, which 
is copyrighted 2012 Microsoft.

If you took functions directly from hyperv_fb, you have to use the same 
license! hyperv_fb is GPL-2.0-only; yours is GPL-2.0.

Best regards
Thomas

> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210218/2fa22992/attachment.sig>


More information about the dri-devel mailing list