[PATCH 00/30] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers
Lyude Paul
lyude at redhat.com
Fri Feb 19 21:52:56 UTC 2021
Since it's been asked quite a few times on some of the various DP
related patch series I've submitted to use the new DRM printk helpers,
and it technically wasn't really trivial to do this before due to the
lack of a consistent way to find a drm_device for an AUX channel, this
patch series aims to address this. In this series we:
* Clean-up potentially erroneous usages of drm_dp_aux_init() and
drm_dp_aux_register() so that actual AUX registration doesn't happen
until we have an associated DRM device
* Clean-up any obvious errors in drivers we find along the way
* Add a backpointer to the respective drm_device for an AUX channel in
drm_dp_aux.drm_dev, and hook it up in every driver with an AUX channel
across the tree
* Add a new ratelimited print helper we'll need for converting the DP
helpers over to using the new DRM printk helpers
* Fix any inconsistencies with logging in drm_dp_helper.c so we always
have the aux channel name printed
* Prepare the various DP helpers so they can find the correct drm_device
to use for logging
* And finally, convert all of the DP helpers over to using drm_dbg_*()
and drm_err().
Lyude Paul (30):
drm/dp: Rewrap kdocs for struct drm_dp_aux
drm/dp: Fixup kernel docs for struct drm_dp_aux
drm/tegra: Don't register DP AUX channels before connectors
drm/bridge/tc358767: Don't register DP AUX channel until bridge is
attached
drm/bridge/cdns-mhdp8546: Register DP aux channel with userspace
drm/bridge/ti-sn65dsi86: (Un)register aux device on bridge
attach/detach
drm/bridge/analogix/anx78xx: Add missing drm_dp_aux_unregister() call
drm/bridge/analogix/anx78xx: Setup encoder before registering
connector
drm/bridge/analogix/anx78xx: Cleanup on error in
anx78xx_bridge_attach()
drm/bridge/analogix/anx6345: Add missing drm_dp_aux_unregister() call
drm/bridge/analogix/anx6345: Don't link encoder until after connector
registration
drm/bridge/analogix/anx6345: Cleanup on errors in
anx6345_bridge_attach()
drm/bridge/analogix/dp_core: Unregister DP AUX channel on error in
analogix_dp_probe()
drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late
register/early unregister
drm/dp: Add backpointer to drm_device in drm_dp_aux
drm/dp: Rewrap drm_dp_aux_register()/drm_dp_aux_init() kdocs
drm/dp: Clarify DP AUX registration time
drm/print: Fixup DRM_DEBUG_KMS_RATELIMITED()
drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()
drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()
drm/dp: Always print aux channel name in logs
drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_detect()
drm/dp_dual_mode: Pass drm_device to
drm_dp_dual_mode_set_tmds_output()
drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_max_tmds_clock()
drm/dp_dual_mode: Pass drm_device to
drm_dp_dual_mode_get_tmds_output()
drm/dp_dual_mode: Pass drm_device to drm_lspcon_(get|set)_mode()
drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw()
drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*()
drm/dp_dual_mode: Convert drm_dp_dual_mode_helper.c to using
drm_err/drm_dbg_kms()
drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 5 +-
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 1 +
.../drm/bridge/analogix/analogix-anx6345.c | 28 +-
.../drm/bridge/analogix/analogix-anx78xx.c | 28 +-
.../drm/bridge/analogix/analogix_dp_core.c | 2 +
.../drm/bridge/cadence/cdns-mhdp8546-core.c | 12 +-
drivers/gpu/drm/bridge/tc358767.c | 21 +-
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 19 +-
drivers/gpu/drm/drm_dp_aux_dev.c | 6 +
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 68 ++--
drivers/gpu/drm/drm_dp_helper.c | 175 ++++----
drivers/gpu/drm/drm_dp_mst_topology.c | 377 +++++++++---------
drivers/gpu/drm/i915/display/intel_dp_aux.c | 1 +
.../drm/i915/display/intel_dp_link_training.c | 6 +-
drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +-
drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +-
drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +-
drivers/gpu/drm/msm/dp/dp_ctrl.c | 6 +-
drivers/gpu/drm/msm/edp/edp.h | 3 +-
drivers/gpu/drm/msm/edp/edp_aux.c | 5 +-
drivers/gpu/drm/msm/edp/edp_ctrl.c | 8 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 27 +-
drivers/gpu/drm/radeon/atombios_dp.c | 5 +-
drivers/gpu/drm/tegra/dpaux.c | 12 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +-
include/drm/drm_dp_dual_mode_helper.h | 14 +-
include/drm/drm_dp_helper.h | 59 +--
include/drm/drm_dp_mst_helper.h | 3 +-
include/drm/drm_print.h | 20 +-
29 files changed, 537 insertions(+), 406 deletions(-)
--
2.29.2
More information about the dri-devel
mailing list