[PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

[Thomas Zimmermann]

Hi

Am 05.01.21 um 12:04 schrieb Gerd Hoffmann:
>    Hi,
> 
>>> It's not possible to do page flip with this virtual device. The call to
>>> SYNTHVID_VRAM_LOCATION is only honoured once. So unfortunately need to
>>> use SHMEM helpers.
>>
>> I was thinking about using struct video_output_situation.vram_offset; in
>> case you want to tinker with that. There's a comment in the patch that
>> vram_offset should always be 0. But this comment seems incorrect for devices
>> with more than one output.
> 
> Where does the comment come from?  fbdev drivers support a single
> framebuffer only so for a fbdev driver it makes sense to set the offset
> to 0 unconditionally.  With drm you probably can handle things
> differently ...

I cannot find it in hyperv_fb.c; it must have gotten introduced here.

Only one display is supported by this DRM driver, so the comment is 
correct. In the future, having support for multiple displays might be an 
option.

Best regards
Thomas

> 
> take care,
>    Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210105/9026c973/attachment-0001.sig>