[PATCH 1/2] drm/radeon: stop re-init the TTM page pool

Borislav Petkov bp at alien8.de
Sat Jan 9 11:10:35 UTC 2021


On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>  	}
>  	rdev->mman.initialized = true;
>  
> -	ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> -		      dma_addressing_limited(&rdev->pdev->dev));
> -
>  	r = radeon_ttm_init_vram(rdev);
>  	if (r) {
>  		DRM_ERROR("Failed initializing VRAM heap.\n");
> -- 

Was finally able to test those during workstation hw maintenance so I
was able to install a new kernel and reboot.

Reported-by: Borislav Petkov <bp at suse.de>
Tested-by: Borislav Petkov <bp at suse.de>

Thanks for the fixes!

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


More information about the dri-devel mailing list