[PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

[Simon Ser]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, January 25th, 2021 at 5:00 PM, Mario Kleiner <mario.kleiner.de at gmail.com> wrote:

> On Mon, Jan 25, 2021 at 1:14 PM Simon Ser <contact at emersion.fr> wrote:
>
> > > This is not an uapi defintion anyway so fixing should be fine.
> >
> > Oh, my bad, I thought this was in drm_mode.h, but it's not. Then yeah
> >
> > should be completely fine to fix it.
>
> Good! The beginning of the end of a sad story ;). So i guess i can
> get your r-b's for it?

Sorry, I haven't verified that this wouldn't break the world, so I'm
not comfortable giving a R-b.

> Will this fix propagate into igt and libdrm? Or are separate fixup patches needed?

No, since this is not part of UAPI.

> Simon, could you let the Kodi devs know in case you have a line to
> them? I didn't know that there is even one more real-world HDR client
> for Linux, apart from AMD's amdvlk Vulkan driver, which does things
> right and doesn't need fixing.

Seems like Kodi hardcodes the bad version:

https://github.com/xbmc/xbmc/blob/aa5c2e79c069ba7d0ab1d8ad930e4294bf554680/xbmc/cores/VideoPlayer/Buffers/VideoBufferDRMPRIME.h#L24

Maybe we should add the good version in UAPI header?