[PATCH v3 4/5] amba: Make the remove callback return void

Vinod Koul vkoul at kernel.org
Tue Jan 26 17:30:40 UTC 2021


On 26-01-21, 17:58, Uwe Kleine-König wrote:
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
> 
> Change the remove prototype to return void, which makes it explicit that
> returning an error value doesn't work as expected. This simplifies changing
> the core remove callback to return void, too.
> 
> Reviewed-by: Ulf Hansson <ulf.hansson at linaro.org>
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni at bootlin.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk at kernel.org> # for drivers/memory
> Acked-by: Mark Brown <broonie at kernel.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  drivers/amba/bus.c                                 | 5 ++---
>  drivers/char/hw_random/nomadik-rng.c               | 3 +--
>  drivers/dma/pl330.c                                | 3 +--

For dmaengine:

Acked-By: Vinod Koul <vkoul at kernel.org>

-- 
~Vinod


More information about the dri-devel mailing list