[Intel-gfx] [PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev
Chris Wilson
chris at chris-wilson.co.uk
Wed Jan 27 12:54:58 UTC 2021
Quoting Thomas Zimmermann (2021-01-27 12:41:34)
> Using struct drm_device.pdev is deprecated. Don't assign it. Users
> should upcast from struct drm_device.dev.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 700aeb923fcd..954ad590089c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -787,7 +787,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (IS_ERR(i915))
> return i915;
>
> - i915->drm.pdev = pdev;
> pci_set_drvdata(pdev, i915);
>
> /* Device parameters start as a copy of module parameters. */
Stick the mock
- i915->drm.pdev = pdev;
in this patch, and I'm happy.
With that, the series is
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris
More information about the dri-devel
mailing list