[PATCH] drm/dbi: Print errors for mipi_dbi_command()

Sam Ravnborg sam at ravnborg.org
Fri Jul 2 10:26:56 UTC 2021


Hi Linus,

On Fri, Jul 02, 2021 at 11:58:52AM +0200, Linus Walleij wrote:
> On Fri, Jul 2, 2021 at 7:45 AM Sam Ravnborg <sam at ravnborg.org> wrote:
> 
> > > -     ret = mipi_dbi_command(dbi, MIPI_DCS_SOFT_RESET);
> > > +     ret = mipi_dbi_command_buf(dbi, MIPI_DCS_SOFT_RESET, NULL, 0);
> > >       if (ret) {
> > >               DRM_DEV_ERROR(dev, "Failed to send reset command (%d)\n", ret);
> > >               if (dbidev->regulator)
> >
> > I do not see the value in this change??
> > There are many other mipi_dbi_command() users and the error return
> > continues to be checked?!??!
> 
> When we change the mipi_dbi_command() macro to check the error
> value we can no longer retrieve the return value from the macro
> so we need to use the call the command buf directly so that we
> can obtain the return code.
Thanks, got it now.

	Sam


More information about the dri-devel mailing list