[PATCH] drm/panel: Document internal backlight handling

Linus Walleij linus.walleij at linaro.org
Thu Jul 15 08:00:17 UTC 2021


Panels with internal backlight need to assign their backlight member
directly.

Reported-by: Doug Anderson <dianders at chromium.org>
Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
---
 include/drm/drm_panel.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
index 33605c3f0eba..1e63fadf1368 100644
--- a/include/drm/drm_panel.h
+++ b/include/drm/drm_panel.h
@@ -144,8 +144,9 @@ struct drm_panel {
 	 * Backlight device, used to turn on backlight after the call
 	 * to enable(), and to turn off backlight before the call to
 	 * disable().
-	 * backlight is set by drm_panel_of_backlight() and drivers
-	 * shall not assign it.
+	 * External backlight is assigned by drm_panel_of_backlight() while
+	 * panel-internal backlight is assigned directly to this member by the
+	 * panel driver.
 	 */
 	struct backlight_device *backlight;
 
-- 
2.31.1



More information about the dri-devel mailing list