[PATCH] drm/omapdrm: Remove outdated comment

Thomas Zimmermann tzimmermann at suse.de
Thu Jul 15 08:13:09 UTC 2021


ping for review

Am 06.07.21 um 09:31 schrieb Thomas Zimmermann:
> The comment refers to drm_irq_install() et al, which are not used by
> omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't
> be used any longer. Remove the comment.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>   drivers/gpu/drm/omapdrm/omap_irq.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c
> index bb6e3fc18204..4aca14dab927 100644
> --- a/drivers/gpu/drm/omapdrm/omap_irq.c
> +++ b/drivers/gpu/drm/omapdrm/omap_irq.c
> @@ -253,13 +253,6 @@ static const u32 omap_underflow_irqs[] = {
>   	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
>   };
> 
> -/*
> - * We need a special version, instead of just using drm_irq_install(),
> - * because we need to register the irq via omapdss.  Once omapdss and
> - * omapdrm are merged together we can assign the dispc hwmod data to
> - * ourselves and drop these and just use drm_irq_{install,uninstall}()
> - */
> -
>   int omap_drm_irq_install(struct drm_device *dev)
>   {
>   	struct omap_drm_private *priv = dev->dev_private;
> --
> 2.32.0
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210715/118e2e2f/attachment.sig>


More information about the dri-devel mailing list