[PATCH] drm/tegra: Fix compilation of variadic macro

Mikko Perttunen cyndis at kapsi.fi
Fri Jul 16 13:01:36 UTC 2021


On 7/16/21 3:46 PM, Jon Hunter wrote:
> Commit 43636451db8c ("drm/tegra: Implement job submission part of new
> UAPI") added the macro 'SUBMIT_ERR' that in turns makes use of the macro
> '__VA_OPT__'. The '__VA_OPT__' macro is not supported by older versions
> of GCC and so causes build failures when using older versions of GCC.
> Fix this by using the '##__VA_ARGS__' macro instead.
> 
> Fixes: 43636451db8c ("drm/tegra: Implement job submission part of new UAPI")
> Reported-by: Linux Kernel Functional Testing <lkft at linaro.org>
> Signed-off-by: Jon Hunter <jonathanh at nvidia.com>
> ---
>   drivers/gpu/drm/tegra/submit.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
> index c53b7207c478..e49630089149 100644
> --- a/drivers/gpu/drm/tegra/submit.c
> +++ b/drivers/gpu/drm/tegra/submit.c
> @@ -24,7 +24,7 @@
>   #define SUBMIT_ERR(context, fmt, ...) \
>   	dev_err_ratelimited(context->client->base.dev, \
>   		"%s: job submission failed: " fmt "\n", \
> -		current->comm __VA_OPT__(,) __VA_ARGS__)
> +		current->comm, ##__VA_ARGS__)
>   
>   static struct tegra_drm_mapping *
>   tegra_drm_mapping_get(struct tegra_drm_context *context, u32 id)
> 

Thanks for taking care of this.

Reviewed-by: Mikko Perttunen <mperttunen at nvidia.com>


More information about the dri-devel mailing list