[PATCH] video: fbdev: arcfb: remove redundant initialization of variable err
Sam Ravnborg
sam at ravnborg.org
Wed Jul 21 11:11:01 UTC 2021
Hi Colin,
On Wed, Jul 21, 2021 at 11:26:08AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The variable err is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> drivers/video/fbdev/arcfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
> index 1447324ed0b6..45e64016db32 100644
> --- a/drivers/video/fbdev/arcfb.c
> +++ b/drivers/video/fbdev/arcfb.c
> @@ -446,7 +446,7 @@ static ssize_t arcfb_write(struct fb_info *info, const char __user *buf,
> /* modded from epson 1355 */
>
> unsigned long p;
> - int err=-EINVAL;
> + int err;
> unsigned int fbmemlength,x,y,w,h, bitppos, startpos, endpos, bitcount;
> struct arcfb_par *par;
> unsigned int xres;
thnaks, applied to drm-misc-next.
It will show up in -next within a week.
Sam
More information about the dri-devel
mailing list