[PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

Inki Dae daeinki at gmail.com
Mon Jul 26 02:36:01 UTC 2021


Sorry for late and thanks for fixing it.

Thanks,
Inki Dae

2021년 6월 16일 수요일, Wei Yongjun <weiyongjun1 at huawei.com>님이 작성:

> Add the missing unlock before return from function g2d_runqueue_worker()
> in the error handling case.
>
> Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index cab4d2c370a7..0ed665501ac4 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct
> *work)
>                         ret = pm_runtime_resume_and_get(g2d->dev);
>                         if (ret < 0) {
>                                 dev_err(g2d->dev, "failed to enable G2D
> device.\n");
> -                               return;
> +                               goto out;
>                         }
>
>                         g2d_dma_start(g2d, g2d->runqueue_node);
>                 }
>         }
>
> +out:
>         mutex_unlock(&g2d->runqueue_mutex);
>  }
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210726/abc2551b/attachment.htm>


More information about the dri-devel mailing list