[PATCH 1/1] drm/panfrost: remove spamming to syslog

Eero Lehtinen debiangamer2 at gmail.com
Tue Jun 8 17:18:42 UTC 2021


This patch removes Panfrost spamming messages to syslog that causes a
poor performance and crashes of the Xfce desktop with a Amlogic S912
TV box. See the old bug in:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/3143

Signed-off-by: Eero Lehtinen <debiangamer2 at gmail.com>

--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -36,8 +36,8 @@
     ret = readl_relaxed_poll_timeout_atomic(pfdev->iomem + AS_STATUS(as_nr),
         val, !(val & AS_STATUS_AS_ACTIVE), 10, 1000);

-    if (ret)
-        dev_err(pfdev->dev, "AS_ACTIVE bit stuck\n");
+    //if (ret)
+    //    dev_err(pfdev->dev, "AS_ACTIVE bit stuck\n");

     return ret;
 }

--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -292,8 +292,8 @@
         prot |= IOMMU_NOEXEC;

     sgt = drm_gem_shmem_get_pages_sgt(obj);
-    if (WARN_ON(IS_ERR(sgt)))
-        return PTR_ERR(sgt);
+    //if (WARN_ON(IS_ERR(sgt)))
+    //    return PTR_ERR(sgt);

     mmu_map_sg(pfdev, mapping->mmu, mapping->mmnode.start << PAGE_SHIFT,
            prot, sgt);

--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -660,7 +660,7 @@
         ret = -1;
         if ((status & mask) == BIT(as) && (exception_type & 0xF8) == 0xC0)
             ret = panfrost_mmu_map_fault_addr(pfdev, as, addr);
-
+#if 0
         if (ret)
             /* terminal fault, print info about the fault */
             dev_err(pfdev->dev,
@@ -678,7 +678,7 @@
                 exception_type, panfrost_exception_name(pfdev, exception_type),
                 access_type, access_type_name(pfdev, fault_status),
                 source_id);
-
+#endif
         status &= ~mask;

         /* If we received new MMU interrupts, process them before returning. */

--- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c
@@ -85,8 +85,8 @@

     mutex_unlock(&pfdev->shrinker_lock);

-    if (freed > 0)
-        pr_info_ratelimited("Purging %lu bytes\n", freed << PAGE_SHIFT);
+    // if (freed > 0)
+        // pr_info_ratelimited("Purging %lu bytes\n", freed << PAGE_SHIFT);

     return freed;
 }


More information about the dri-devel mailing list