[PATCH] drm/bridge: ti-sn65dsi83: Fix sparse warnings

[Robert Foss]

Hey Marek,

Thanks for submitting this.

On Tue, 8 Jun 2021 at 16:22, Marek Vasut <marex at denx.de> wrote:
>
> Fix the following sparse warnings generated by "make C=1":
>
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: warning: incorrect type in assignment (different base types)
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13:    expected unsigned short [assigned] [usertype] val
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13:    got restricted __le16 [usertype]
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13: warning: incorrect type in assignment (different base types)
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13:    expected unsigned short [addressable] [assigned] [usertype] val
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:432:13:    got restricted __le16 [usertype]
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13: warning: incorrect type in assignment (different base types)
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13:    expected unsigned short [addressable] [assigned] [usertype] val
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:436:13:    got restricted __le16 [usertype]
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13: warning: incorrect type in assignment (different base types)
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13:    expected unsigned short [addressable] [assigned] [usertype] val
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:438:13:    got restricted __le16 [usertype]
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13: warning: incorrect type in assignment (different base types)
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13:    expected unsigned short [addressable] [assigned] [usertype] val
> drivers/gpu/drm/bridge/ti-sn65dsi83.c:441:13:    got restricted __le16 [usertype]
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Adam Ford <aford173 at gmail.com>
> Cc: Douglas Anderson <dianders at chromium.org>
> Cc: Frieder Schrempf <frieder.schrempf at kontron.de>
> Cc: Jagan Teki <jagan at amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Loic Poulain <loic.poulain at linaro.org>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Philippe Schenker <philippe.schenker at toradex.com>
> Cc: Robert Foss <robert.foss at linaro.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Stephen Boyd <swboyd at chromium.org>
> Cc: Valentin Raevsky <valentin at compulab.co.il>
> To: dri-devel at lists.freedesktop.org
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 750f2172ef08..8f3158f5281a 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -368,6 +368,7 @@ static void sn65dsi83_enable(struct drm_bridge *bridge)
>  {
>         struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge);
>         unsigned int pval;
> +       __le16 le16val;
>         u16 val;
>         int ret;
>
> @@ -426,21 +427,21 @@ static void sn65dsi83_enable(struct drm_bridge *bridge)
>                      REG_LVDS_LANE_CHB_LVDS_TERM);
>         regmap_write(ctx->regmap, REG_LVDS_CM, 0x00);
>
> -       val = cpu_to_le16(ctx->mode.hdisplay);
> +       le16val = cpu_to_le16(ctx->mode.hdisplay);
>         regmap_bulk_write(ctx->regmap, REG_VID_CHA_ACTIVE_LINE_LENGTH_LOW,
> -                         &val, 2);
> -       val = cpu_to_le16(ctx->mode.vdisplay);
> +                         &le16val, 2);
> +       le16val = cpu_to_le16(ctx->mode.vdisplay);
>         regmap_bulk_write(ctx->regmap, REG_VID_CHA_VERTICAL_DISPLAY_SIZE_LOW,
> -                         &val, 2);
> +                         &le16val, 2);
>         /* 32 + 1 pixel clock to ensure proper operation */
> -       val = cpu_to_le16(32 + 1);
> -       regmap_bulk_write(ctx->regmap, REG_VID_CHA_SYNC_DELAY_LOW, &val, 2);
> -       val = cpu_to_le16(ctx->mode.hsync_end - ctx->mode.hsync_start);
> +       le16val = cpu_to_le16(32 + 1);
> +       regmap_bulk_write(ctx->regmap, REG_VID_CHA_SYNC_DELAY_LOW, &le16val, 2);
> +       le16val = cpu_to_le16(ctx->mode.hsync_end - ctx->mode.hsync_start);
>         regmap_bulk_write(ctx->regmap, REG_VID_CHA_HSYNC_PULSE_WIDTH_LOW,
> -                         &val, 2);
> -       val = cpu_to_le16(ctx->mode.vsync_end - ctx->mode.vsync_start);
> +                         &le16val, 2);
> +       le16val = cpu_to_le16(ctx->mode.vsync_end - ctx->mode.vsync_start);
>         regmap_bulk_write(ctx->regmap, REG_VID_CHA_VSYNC_PULSE_WIDTH_LOW,
> -                         &val, 2);
> +                         &le16val, 2);
>         regmap_write(ctx->regmap, REG_VID_CHA_HORIZONTAL_BACK_PORCH,
>                      ctx->mode.htotal - ctx->mode.hsync_end);
>         regmap_write(ctx->regmap, REG_VID_CHA_VERTICAL_BACK_PORCH,

Reviewed and pulled into drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=241a9e233e7cf1001d09426c9fc520768f8961bf