[PATCH v2 02/12] drm/panfrost: Get rid of the unused JS_STATUS_EVENT_ACTIVE definition

[Steven Price]

On 21/06/2021 15:49, Boris Brezillon wrote:
> On Mon, 21 Jun 2021 15:34:35 +0100
> Steven Price <steven.price at arm.com> wrote:
> 
>> On 21/06/2021 14:38, Boris Brezillon wrote:
>>> Exception types will be defined as an enum in panfrost_drm.h so userspace
>>> and use the same definitions if needed.  
>>
>> s/and/can/ ?
>>
>> While it is (currently) unused in the kernel, this is a hardware value
>> so I'm not sure why it's worth removing this and not the other
>> (currently) unused values here. This is the value returned from the
>> JS_STATUS register when the slot is actively processing a job.
> 
> Hm, what's the point of having the same value defined in 2 places
> (DRM_PANFROST_EXCEPTION_ACTIVE defined in patch 3 vs
> JS_STATUS_EVENT_ACTIVE here)? I mean, values defined in the
> drm_panfrost_exception_type enum apply to the JS_STATUS registers too,
> right?

Thinking about this more I guess I agree with you: this is an oddity and
your following patch adds a (more) complete list. You've convinced me -
with my nit above fixed:

Reviewed-by: Steven Price <steven.price at arm.com>