[PATCH 1/1] drm/kmb: Fix error return code in kmb_hw_init()

[Chrisanthus, Anitha]

Thanks for the patch. Patch pushed to drm-misc-fixes.

Anitha

> -----Original Message-----
> From: Chrisanthus, Anitha
> Sent: Thursday, May 13, 2021 10:12 AM
> To: Zhen Lei <thunder.leizhen at huawei.com>; Dea, Edmund J
> <edmund.j.dea at intel.com>; David Airlie <airlied at linux.ie>; Daniel Vetter
> <daniel at ffwll.ch>; Sam Ravnborg <sam at ravnborg.org>; dri-devel <dri-
> devel at lists.freedesktop.org>
> Subject: RE: [PATCH 1/1] drm/kmb: Fix error return code in kmb_hw_init()
> 
> Thanks for the patch.
> 
> Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus at intel.com>
> 
> > -----Original Message-----
> > From: Zhen Lei <thunder.leizhen at huawei.com>
> > Sent: Thursday, May 13, 2021 6:47 AM
> > To: Chrisanthus, Anitha <anitha.chrisanthus at intel.com>; Dea, Edmund J
> > <edmund.j.dea at intel.com>; David Airlie <airlied at linux.ie>; Daniel Vetter
> > <daniel at ffwll.ch>; Sam Ravnborg <sam at ravnborg.org>; dri-devel <dri-
> > devel at lists.freedesktop.org>
> > Cc: Zhen Lei <thunder.leizhen at huawei.com>
> > Subject: [PATCH 1/1] drm/kmb: Fix error return code in kmb_hw_init()
> >
> > When call platform_get_irq() to obtain the IRQ of the lcd fails, the
> > returned error code should be propagated. However, we currently do not
> > explicitly assign this error code to 'ret'. As a result, 0 was incorrectly
> > returned.
> >
> > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
> > Reported-by: Hulk Robot <hulkci at huawei.com>
> > Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
> > ---
> >  drivers/gpu/drm/kmb/kmb_drv.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> > b/drivers/gpu/drm/kmb/kmb_drv.c
> > index f64e06e1067dd8d..96ea1a2c11dd6a3 100644
> > --- a/drivers/gpu/drm/kmb/kmb_drv.c
> > +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> > @@ -137,6 +137,7 @@ static int kmb_hw_init(struct drm_device *drm,
> > unsigned long flags)
> >  	/* Allocate LCD interrupt resources */
> >  	irq_lcd = platform_get_irq(pdev, 0);
> >  	if (irq_lcd < 0) {
> > +		ret = irq_lcd;
> >  		drm_err(&kmb->drm, "irq_lcd not found");
> >  		goto setup_fail;
> >  	}
> > --
> > 2.26.0.106.g9fadedd
> >