答复: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally

[tiantao (H)]

-----邮件原件-----
发件人: Thomas Zimmermann [mailto:tzimmermann at suse.de] 
发送时间: 2021年6月22日 22:10
收件人: daniel at ffwll.ch; airlied at linux.ie; alexander.deucher at amd.com; christian.koenig at amd.com; Xinhui.Pan at amd.com; james.qian.wang at arm.com; liviu.dudau at arm.com; mihail.atanassov at arm.com; brian.starkey at arm.com; maarten.lankhorst at linux.intel.com; mripard at kernel.org; inki.dae at samsung.com; jy0922.shim at samsung.com; sw0312.kim at samsung.com; kyungmin.park at samsung.com; krzysztof.kozlowski at canonical.com; xinliang.liu at linaro.org; tiantao (H) <tiantao6 at hisilicon.com>; john.stultz at linaro.org; kongxinwei (A) <kong.kongxinwei at hisilicon.com>; Chenfeng (puck) <puck.chen at hisilicon.com>; laurentiu.palcu at oss.nxp.com; l.stach at pengutronix.de; p.zabel at pengutronix.de; shawnguo at kernel.org; s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com; linux-imx at nxp.com; chunkuang.hu at kernel.org; matthias.bgg at gmail.com; bskeggs at redhat.com; tomba at kernel.org; hjc at rock-chips.com; heiko at sntech.de; benjamin.gaignard at linaro.org; yannick.fertre at foss.st.com; philippe.cornu at foss.st.com; mcoquelin.stm32 at gmail.com; alexandre.torgue at foss.st.com; wens at csie.org; jernej.skrabec at gmail.com; thierry.reding at gmail.com; jonathanh at nvidia.com; jyri.sarha at iki.fi; emma at anholt.net; linux-graphics-maintainer at vmware.com; zackr at vmware.com; hyun.kwon at xilinx.com; laurent.pinchart at ideasonboard.com; michal.simek at xilinx.com
抄送: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; linux-arm-kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.org; linux-mediatek at lists.infradead.org; nouveau at lists.freedesktop.org; linux-rockchip at lists.infradead.org; linux-stm32 at st-md-mailman.stormreply.com; linux-sunxi at lists.linux.dev; linux-tegra at vger.kernel.org; Thomas Zimmermann <tzimmermann at suse.de>
主题: [PATCH v2 02/22] drm/hibmc: Call drm_irq_uninstall() unconditionally

Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Tian Tao <tiantao6 at hisilicon.com>

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f4bc5386574a..f8ef711bbe5d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)  {
 	drm_atomic_helper_shutdown(dev);
 
-	if (dev->irq_enabled)
-		drm_irq_uninstall(dev);
+	drm_irq_uninstall(dev);
 
 	pci_disable_msi(to_pci_dev(dev->dev));
 
--
2.32.0