[PATCH v3 02/15] drm/panfrost: Make ->run_job() return an ERR_PTR() when appropriate
Alyssa Rosenzweig
alyssa at collabora.com
Fri Jun 25 13:45:43 UTC 2021
R-b
On Fri, Jun 25, 2021 at 03:33:14PM +0200, Boris Brezillon wrote:
> If the fence creation fail, we can return the error pointer directly.
> The core will update the fence error accordingly.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> Reviewed-by: Steven Price <steven.price at arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 8ff79fd49577..d6c9698bca3b 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -355,7 +355,7 @@ static struct dma_fence *panfrost_job_run(struct drm_sched_job *sched_job)
>
> fence = panfrost_fence_create(pfdev, slot);
> if (IS_ERR(fence))
> - return NULL;
> + return fence;
>
> if (job->done_fence)
> dma_fence_put(job->done_fence);
> --
> 2.31.1
>
More information about the dri-devel
mailing list