[PATCH] drm: rcar-du: Use drmm_encoder_alloc() to manage encoder

Kieran Bingham kieran.bingham+renesas at ideasonboard.com
Mon Mar 1 11:52:26 UTC 2021


Laurent,



On 01/03/2021 10:30, Geert Uytterhoeven wrote:
> On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven
> <geert at linux-m68k.org> wrote:
>> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham
>> <kieran.bingham+renesas at ideasonboard.com> wrote:
>>> The encoder allocation was converted to a DRM managed resource at the
>>> same time as the addition of a new helper drmm_encoder_alloc() which
>>> simplifies the same process.
>>>
>>> Convert the custom drm managed resource allocation of the encoder
>>> with the helper to simplify the implementation, and prevent hitting a
>>> WARN_ON() due to the handling the drm_encoder_init() call directly
>>> without registering a .destroy() function op.
>>>
>>> Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders")
>>> Reported-by: Geert Uytterhoeven <geert+renesas at glider.be>
>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas at ideasonboard.com>
>>
>> Tested-by: Geert Uytterhoeven <geert+renesas at glider.be>
>> As in "the WARNING from drm_encoder_init() is gone".
> 
> JFYI, the WARNING is now in v5.12-rc1, the fix isn't.

Does this patch go through you to get into the DRM tree? Or do I need to
re-send it to someone else?

> Gr{oetje,eeting}s,
> 
>                         Geert
> 



More information about the dri-devel mailing list