rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type

[Kieran Bingham]

On 01/03/2021 18:52, Greg Kroah-Hartman wrote:
> On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
>> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
>>
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
>> declaration of function 'to_rcar_du_device'; did you mean
>> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>>                                 ^~~~~~~~~~~~~~~~~
>>                                 to_rtc_device
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
>> makes pointer from integer without a cast [-Wint-conversion]
>> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
>> 1 of '__drmm_add_action' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
>>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>>                         ^
>> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>>   __drmm_add_action(dev, action, data, #action)
>>                     ^~~
>> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
>> but argument is of type 'struct drm_device **'
>>  int __must_check __drmm_add_action(struct drm_device *dev,
>>                   ^~~~~~~~~~~~~~~~~
>> cc1: some warnings being treated as errors
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju at linaro.org>
> 
> Very odd, my builds here didn't trigger that, sorry.  I'll go drop the
> offending patch...

Hrm, I believe this should have been fixed by:

https://lore.kernel.org/dri-devel/20210113170253.443820-1-kieran.bingham+renesas@ideasonboard.com/

But it doesn't seem to have made it upstream yet.

I've pinged the patch today, but that won't help stable trees until it
lands.
--
Kieran