[PATCH] drm/exynos/decon5433: Clean up GPIO includes

Inki Dae inki.dae at samsung.com
Mon Mar 15 06:35:48 UTC 2021


Hi Tian Tao,

21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
> remove the legacy GPIO headers <linux/of_gpio.h> but what it really
> uses is <linux/gpio/consumer.h> since only gpio_desc structs are ever
> referenced.

This driver doesn't reference even linux/gpio/consumer.h so could you drop only of_gpio.h inclusion?

Thanks,
Inki Dae

> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>
> ---
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 1f79bc2..9fc51a6 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -11,9 +11,9 @@
>  #include <linux/component.h>
>  #include <linux/iopoll.h>
>  #include <linux/irq.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/regmap.h>
> 


More information about the dri-devel mailing list