[PATCH] drm/tegra: dpaux: move to use request_irq by IRQF_NO_AUTOEN flag
Tian Tao
tiantao6 at hisilicon.com
Wed Mar 17 06:26:25 UTC 2021
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>
---
drivers/gpu/drm/tegra/dpaux.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 105fb9c..0acaf66 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -521,7 +521,8 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);
- err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq, 0,
+ err = devm_request_irq(dpaux->dev, dpaux->irq, tegra_dpaux_irq,
+ IRQF_NO_AUTOEN,
dev_name(dpaux->dev), dpaux);
if (err < 0) {
dev_err(dpaux->dev, "failed to request IRQ#%u: %d\n",
@@ -529,8 +530,6 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
return err;
}
- disable_irq(dpaux->irq);
-
dpaux->aux.transfer = tegra_dpaux_transfer;
dpaux->aux.dev = &pdev->dev;
--
2.7.4
More information about the dri-devel
mailing list