[PATCH 1/3] drm/ttm: move swapout logic around v2
Christian König
ckoenig.leichtzumerken at gmail.com
Fri Mar 19 12:07:05 UTC 2021
General question for the audience: Is there any way to silence the build
bot here?
This is a well known false positive.
Regards,
Christian.
Am 18.03.21 um 19:13 schrieb kernel test robot:
> Hi "Christian,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on drm-tip/drm-tip]
> [also build test ERROR on next-20210318]
> [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next linus/master v5.12-rc3]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-move-swapout-logic-around-v2/20210318-204848
> base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> config: x86_64-randconfig-a005-20210318 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/a454d56ea061b53d24a62a700743e4508dd6c9b1
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Christian-K-nig/drm-ttm-move-swapout-logic-around-v2/20210318-204848
> git checkout a454d56ea061b53d24a62a700743e4508dd6c9b1
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp at intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> drivers/gpu/drm/ttm/ttm_device.c:109:5: error: conflicting types for 'ttm_global_swapout'
> int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
> ^
> include/drm/ttm/ttm_device.h:300:6: note: previous declaration is here
> long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags);
> ^
> 1 error generated.
>
>
> vim +/ttm_global_swapout +109 drivers/gpu/drm/ttm/ttm_device.c
>
> 104
> 105 /**
> 106 * A buffer object shrink method that tries to swap out the first
> 107 * buffer object on the global::swap_lru list.
> 108 */
> > 109 int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
> 110 {
> 111 struct ttm_global *glob = &ttm_glob;
> 112 struct ttm_buffer_object *bo;
> 113 unsigned i;
> 114 int ret;
> 115
> 116 spin_lock(&glob->lru_lock);
> 117 for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
> 118 list_for_each_entry(bo, &glob->swap_lru[i], swap) {
> 119 uint32_t num_pages = bo->ttm->num_pages;
> 120
> 121 ret = ttm_bo_swapout(bo, ctx, gfp_flags);
> 122 /* ttm_bo_swapout has dropped the lru_lock */
> 123 if (!ret)
> 124 return num_pages;
> 125 if (ret != -EBUSY)
> 126 return ret;
> 127 }
> 128 }
> 129 spin_unlock(&glob->lru_lock);
> 130 return 0;
> 131 }
> 132 EXPORT_SYMBOL(ttm_global_swapout);
> 133
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
More information about the dri-devel
mailing list