[PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

Daniel Stone daniel at fooishbar.org
Wed Mar 24 15:25:03 UTC 2021


Hi Mark,

On Wed, 24 Mar 2021 at 14:58, Mark Yacoub <markyacoub at chromium.org> wrote:

> So you mean it would make more sense to be more explicit in handling
> DRM_FORMAT_MOD_INVALID as an incoming modifier (which will, just like
> DRM_FORMAT_MOD_LINEAR, will return true in
> dm_plane_format_mod_supported)?
>

That's correct. Not passing any modifiers is the same as explicitly passing
INVALID, both of which mean 'the driver will figure it out somehow'; that
driver-specific determination is not the same as explicit LINEAR.

(I cannot regret enough that INVALID is not 0.)

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210324/c78d0e13/attachment.htm>


More information about the dri-devel mailing list