[PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling
Stephen Boyd
swboyd at chromium.org
Fri Mar 26 01:18:10 UTC 2021
Quoting Abhinav Kumar (2021-03-05 11:17:19)
> Currently the error checking logic in the dp_debug module could
> pass zero to PTR_ERR and it causes the below kbot warnings:
>
> drivers/gpu/drm/msm/dp/dp_debug.c:378 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:387 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:396 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
> drivers/gpu/drm/msm/dp/dp_debug.c:405 dp_debug_init()
> warn: passing zero to 'PTR_ERR'
>
> Debugfs functions are not supposed to be checked in the normal
> case so delete this code. Also it silences the above Smatch
> warnings that we're checking for NULL when these functions only
> return error pointers.
>
> Reported-by: kernel test robot <lkp at intel.com>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: Abhinav Kumar <abhinavk at codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd at chromium.org>
Nice cleanup!
More information about the dri-devel
mailing list