[bug report] drm/bridge: Introduce LT8912B DSI to HDMI bridge

Adrien Grassein adrien.grassein at gmail.com
Wed Mar 31 09:17:20 UTC 2021


Hello,

thanks for your review.

I will publish a patch soon.

What tag should I add to my commit to mention that you find bugs
(Suggested-by for example)?

Thanks;

Le mer. 31 mars 2021 à 10:14, Dan Carpenter <dan.carpenter at oracle.com> a écrit :
>
> On Wed, Mar 31, 2021 at 11:12:38AM +0300, Dan Carpenter wrote:
> >    644          of_node_put(endpoint);
> >    645
> >    646          lt->host_node = of_graph_get_remote_node(dev->of_node, 0, -1);
> >    647          if (!lt->host_node) {
> >    648                  dev_err(lt->dev, "%s: Failed to get remote port\n", __func__);
> >    649                  ret = -ENODEV;
> >    650                  goto end;
> >    651          }
> >    652
> >    653          port_node = of_graph_get_remote_node(dev->of_node, 1, -1);
> >    654          if (!port_node) {
> >    655                  dev_err(lt->dev, "%s: Failed to get connector port\n", __func__);
> >    656                  ret = -ENODEV;
> >    657                  goto err_free_host_node;
> >    658          }
> >    659
> >    660          lt->hdmi_port = of_drm_find_bridge(port_node);
> >    661          if (IS_ERR(lt->hdmi_port)) {
>
> This isn't an error pointer either.  of_drm_find_bridge() returns NULL.
>
> regards,
> dan carpenter
>
>


More information about the dri-devel mailing list