[PATCH] drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper

Robert Foss robert.foss at linaro.org
Tue May 4 15:54:15 UTC 2021


Merged to drm-misc-next.

On Tue, 4 May 2021 at 17:22, Robert Foss <robert.foss at linaro.org> wrote:

> Hey Douglas,
>
> On Tue, 4 May 2021 at 16:39, Douglas Anderson <dianders at chromium.org>
> wrote:
>
>> The ti_sn_gpio_unregister() is not just called from the remove path
>> but also from the error handling of the init path. That means it can't
>> have the __exit annotation.
>>
>> Fixes: bf73537f411b ("drm/bridge: ti-sn65dsi86: Break GPIO and
>> MIPI-to-eDP bridge into sub-drivers")
>> Reported-by: kernel test robot <lkp at intel.com>
>> Signed-off-by: Douglas Anderson <dianders at chromium.org>
>> ---
>>
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> index db027528febd..bb0a0e1c6341 100644
>> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
>> @@ -1251,7 +1251,7 @@ static int __init ti_sn_gpio_register(void)
>>         return auxiliary_driver_register(&ti_sn_gpio_driver);
>>  }
>>
>> -static void __exit ti_sn_gpio_unregister(void)
>> +static void ti_sn_gpio_unregister(void)
>>  {
>>         auxiliary_driver_unregister(&ti_sn_gpio_driver);
>>  }
>> --
>> 2.31.1.527.g47e6f16901-goog
>>
>>
> Reviewed-by: Robert Foss <robert.foss at linaro.org>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20210504/fef7ea5f/attachment.htm>


More information about the dri-devel mailing list