[PATCH] drm/imx: ipuv3-plane: use drm managed resources

Philipp Zabel p.zabel at pengutronix.de
Mon May 10 14:47:38 UTC 2021


Hi Lucas,

On Mon, 2021-05-10 at 16:29 +0200, Lucas Stach wrote:
> The conversion to drm managed resources introduced two bugs: the plane is now
> always initialized with the linear-only list, while the list with the Vivante
> GPU modifiers should have been used when the PRG/PRE engines are present. This
> masked another issue, as ipu_plane_format_mod_supported() is now called before
> the private plane data is set up, so if a non-linear modifier is supplied in
> the plane modifier list, we run into a NULL pointer dereference checking for
> the PRG presence. To fix this just remove the check from this function, as we
> know that it will only be called with a non-linear modifier, if the plane init
> code has already determined that the PRG/PRE is present.
> 
> Fixes: 699e7e543f1a ("drm/imx: ipuv3-plane: use drm managed resources")
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Thank you, I've rebased and applied this patch on top of imx-drm/next.

regards
Philipp


More information about the dri-devel mailing list