[PATCH 1/1] drm/kmb: Remove redundant error printing in kmb_dsi_map_mmio()

Zhen Lei thunder.leizhen at huawei.com
Tue May 11 09:43:08 UTC 2021


When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen at huawei.com>
---
 drivers/gpu/drm/kmb/kmb_dsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c
index 4b5d82af84b3014..6f278bc018cee67 100644
--- a/drivers/gpu/drm/kmb/kmb_dsi.c
+++ b/drivers/gpu/drm/kmb/kmb_dsi.c
@@ -1468,10 +1468,8 @@ int kmb_dsi_map_mmio(struct kmb_dsi *kmb_dsi)
 		return -ENOMEM;
 	}
 	kmb_dsi->mipi_mmio = devm_ioremap_resource(dev, res);
-	if (IS_ERR(kmb_dsi->mipi_mmio)) {
-		dev_err(dev, "failed to ioremap mipi registers");
+	if (IS_ERR(kmb_dsi->mipi_mmio))
 		return PTR_ERR(kmb_dsi->mipi_mmio);
-	}
 	return 0;
 }
 
-- 
2.26.0.106.g9fadedd




More information about the dri-devel mailing list