[PATCH] drm: Remove unused branch in legacy PCI initialization

Daniel Vetter daniel at ffwll.ch
Mon May 17 14:49:33 UTC 2021


On Sun, May 16, 2021 at 09:19:18PM +0200, Thomas Zimmermann wrote:
> The legacy PCI init code sets the drvdata for drivers with MODESET
> flag, but none of the old UMS drivers sets the flag. Remove the branch.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>

Yeah now that this is legacy-only it really doesn't make sense anymore.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/drm_pci.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
> index 38c3cb72e7e6..f508f70e7a3f 100644
> --- a/drivers/gpu/drm/drm_pci.c
> +++ b/drivers/gpu/drm/drm_pci.c
> @@ -165,9 +165,6 @@ static int drm_legacy_get_pci_dev(struct pci_dev *pdev,
>  	dev->hose = pdev->sysdata;
>  #endif
>  
> -	if (drm_core_check_feature(dev, DRIVER_MODESET))
> -		pci_set_drvdata(pdev, dev);
> -
>  	drm_legacy_pci_agp_init(dev);
>  
>  	ret = drm_dev_register(dev, ent->driver_data);
> -- 
> 2.31.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list