[PATCH] drm/i915: fixup dma_fence_wait usage

Thomas Hellström thomas.hellstrom at linux.intel.com
Tue Nov 2 15:53:43 UTC 2021


On 11/2/21 16:50, Matthew Auld wrote:
> dma_fence_wait expects a boolean for whether it should be interruptible,
> not a timeout value.
>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/i915_vma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index 90546fa58fc1..8781c4f61952 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma)
>   		fence = dma_fence_get_rcu_safe(&vma->active.excl.fence);
>   		rcu_read_unlock();
>   		if (fence) {
> -			err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT);
> +			err = dma_fence_wait(fence, true);
>   			dma_fence_put(fence);
>   		}
>   	}

LGTM. Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>




More information about the dri-devel mailing list