[Bug 214921] amdgpu hangs HP Laptop on shutdown

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=214921

spasswolf at web.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Kernel Version|5.15, 5.15.1                |5.15, 5.15.1,
                   |                            |5.15.0-next-20211112

--- Comment #4 from spasswolf at web.de ---
This still bug is still present in the 5.15.0-next-20211112 where it breaks
suspend:

static int uvd_v6_0_suspend(void *handle)
{
        int r;
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;

        /*
         * Proper cleanups before halting the HW engine:
         *   - cancel the delayed idle work
         *   - enable powergating
         *   - enable clockgating
         *   - disable dpm
         *
         * TODO: to align with the VCN implementation, move the
         * jobs for clockgating/powergating/dpm setting to
         * ->set_powergating_state().
         */
#if 0
        cancel_delayed_work_sync(&adev->uvd.idle_work);

        if (adev->pm.dpm_enabled) {
                amdgpu_dpm_enable_uvd(adev, false);
        } else {
                amdgpu_asic_set_uvd_clocks(adev, 0, 0);
                /* shutdown the UVD block */
                amdgpu_device_ip_set_powergating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
                                                       AMD_PG_STATE_GATE);
                amdgpu_device_ip_set_clockgating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
                                                       AMD_CG_STATE_GATE);
        }
#endif

        r = uvd_v6_0_hw_fini(adev);
        if (r)
                return r;

        return amdgpu_uvd_suspend(adev);
}
This makes suspend work again.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.