[PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
Peter Chen
peter.chen at kernel.org
Tue Nov 23 12:51:08 UTC 2021
On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> > > +++ b/drivers/usb/cdns3/host.c
> > > @@ -10,6 +10,7 @@
> > > */
> > >
> > > #include <linux/platform_device.h>
> > > +#include <linux/slab.h>
> >
> > Should be "#include <linux/module.h>"?
>
> Why? Different files are missing different includes, this one needs
> slab.h:
>
> ../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
> ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> kfree(cdns->xhci_plat_data);
> ^~~~~
> vfree
Oh, my fault.
Acked-by: Peter Chen <peter.chen at kernel.org>
--
Thanks,
Peter Chen
More information about the dri-devel
mailing list