[PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

Konrad Dybcio konrad.dybcio at somainline.org
Tue Oct 5 16:50:45 UTC 2021


[snipping to not have the entire thread here]
> I've no objections to seeing the DT updated. However I don't really see
> what benefit we get from breaking existing DTs in order to do so.
>
> "Cleaning up annoying legacy" is seldom a good reason to break existing
> DTs since, if we could break DTs whenever we choose, there would never
> be any annoying legacy to worry about. When conflicting properties
> result in uninterpretable DTs then a break may be justified but that is
> not the case here.
>
>
> Daniel.

The only true user of wled as of right now is Xperia Tone platform, 
which does not yet

have display support upstream, so unless one classifies lighting up an 
otherwise black display

a dealbreaker, I think it'd be fine to bend the rules this time.


Konrad



More information about the dri-devel mailing list