AW: (EXT) Re: [PATCH 2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

[Alexander Stein]

On Wed, Oct 6, 2021 at 3:21 PM Rob Herring
<robh+dt at kernel.org> wrote:

> On Wed, Oct 6, 2021 at 2:47 AM Alexander Stein
> <alexander.stein at ew.tq-group.com> wrote:
> >
> > Add a VCC regulator which needs to be enabled before the EN pin is
> > released.
> >
> > Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> > ---
> >  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml     | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > index 07b20383cbca..149cff3233c2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > @@ -32,6 +32,9 @@ properties:
> >      maxItems: 1
> >      description: GPIO specifier for bridge_en pin (active high).
> >
> > +  vcc-supply:
> > +    description: A 1.8V power supply (see regulator/regulator.yaml).
> > +
> >    ports:
> >      $ref: /schemas/graph.yaml#/properties/ports
> >
> > @@ -94,6 +97,7 @@ required:
> >    - compatible
> >    - reg
> >    - enable-gpios
> > +  - vcc-supply
>
> You generally can't make added properties required unless all DT files
> already had this property. It breaks compatibility.

I agree, but AFAICS none of the in-kernel DT files uses this binding. I used
'grep -re "ti,sn65dsi8[34]" arch/*/boot/dts' to check. Only
ti,sn65dsi86 is used on some qcom boards, but this is a completly different
binding and driver.

Best regards,
Alexander