[PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

[Sam Ravnborg]

Hi Oleksij, Robin,

On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> 
> Co-Developed-by: Robin van der Gracht <robin at protonic.nl>
> Signed-off-by: Robin van der Gracht <robin at protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel at pengutronix.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 9b6c4e6c38a1..a03b60f6fa99 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
>  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
> +static const struct panel_desc innolux_g070y2_t02 = {
> +	.modes = &innolux_at070tn92_mode,

It is suprising to see that the innolux_g070y2_t02 uses the mode
innolux_at070tn92_mode.
Is it on purpose? If yes then I would expect the changelog to say so.

In most (all?) other cases the panel provide their own mode.

	Sam

> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 152,
> +		.height = 92,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>  static const struct display_timing innolux_g101ice_l01_timing = {
>  	.pixelclock = { 60400000, 71100000, 74700000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -4663,6 +4676,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "innolux,g070y2-l01",
>  		.data = &innolux_g070y2_l01,
> +	}, {
> +		.compatible = "innolux,g070y2-t02",
> +		.data = &innolux_g070y2_t02,
>  	}, {
>  		.compatible = "innolux,g101ice-l01",
>  		.data = &innolux_g101ice_l01
> -- 
> 2.30.2