[PATCH] drm: Link CMA framebuffer helpers into KMS helper library

Sam Ravnborg sam at ravnborg.org
Tue Oct 26 18:46:04 UTC 2021


Hi Thomas,

On Tue, Oct 26, 2021 at 07:57:00PM +0200, Thomas Zimmermann wrote:
> Linking the CMA frambuffer helpers into a CMA helper library in
> commit 4b2b5e142ff4 ("drm: Move GEM memory managers into modules")
> results in linker errors:
> 
>   arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.o: \
> 	  in function `drm_fb_cma_get_gem_obj': \
> 	  drivers/gpu/drm/drm_fb_cma_helper.c:46: undefined reference \
> 	  to `drm_gem_fb_get_obj'
>   arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:46: \
> 	  undefined reference to `drm_gem_fb_get_obj'
>   arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:46: \
> 	  undefined reference to `drm_gem_fb_get_obj'
>   arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.o: in \
> 	  function `drm_fb_cma_sync_non_coherent': \
> 	  drivers/gpu/drm/drm_fb_cma_helper.c:133: undefined reference \
> 	  to `drm_atomic_helper_damage_iter_init'
>   arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:135: \
> 	  undefined reference to `drm_atomic_helper_damage_iter_next'
> 
> Link the CMA framebuffer helpers into the KMS helper library to
> fix the problem.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Fixes: 4b2b5e142ff4 ("drm: Move GEM memory managers into modules")
> Reported-by: Naresh Kamboju <naresh.kamboju at linaro.org>
> Reported-by: Linux Kernel Functional Testing <lkft at linaro.org>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: dri-devel at lists.freedesktop.org

Patch looks fine,
Reviewed-by: Sam Ravnborg <sam at ravnborg.org>

	Sam


More information about the dri-devel mailing list