[PATCH] gpu/drm: ingenic: Remove bogus register write

Paul Cercueil paul at crapouillou.net
Sat Oct 30 20:03:30 UTC 2021


Hi,

Le sam., oct. 30 2021 at 20:49:53 +0200, Sam Ravnborg 
<sam at ravnborg.org> a écrit :
> Hi Paul,
> 
> On Sat, Oct 30, 2021 at 11:00:32AM +0100, Paul Cercueil wrote:
>>  Commit 1bdb542da736 ("drm/ingenic: Simplify code by using hwdescs
>>  array") caused the dma_hwdesc_phys_f{0,1} variables to be used while
>>  uninitialized in a mmio register write, which most certainly broke 
>> the
>>  ingenic-drm driver.
>> 
>>  However, the very same patchset also submitted commit 6055466203df
>>  ("drm/ingenic: Upload palette before frame"), which restored a 
>> correct
>>  behaviour by doing the register writes in a different place in the 
>> code.
>> 
>>  What's left of this, is just to remove the bogus register writes in 
>> the
>>  probe function.
>> 
>>  Signed-off-by: Paul Cercueil <paul at crapouillou.net>
>>  Reported-by: kernel test robot <lkp at intel.com>
> 
> Thank you lkp...
> Acked-by: Sam Ravnborg <sam at ravnborg.org>

Pushed to drm-misc-next.

Thanks!
-Paul




More information about the dri-devel mailing list