[PATCH 2/3] drm/v3d: add generic ioctl extension

[Iago Toral]

On Wed, 2021-09-15 at 17:28 +0100, Melissa Wen wrote:
> On 09/15, Iago Toral wrote:
> > On Wed, 2021-08-18 at 18:56 +0100, Melissa Wen wrote:
(...)
> > > 
> > >  /**
> > > @@ -248,6 +266,15 @@ struct drm_v3d_submit_tfu {
> > >  	__u32 in_sync;
> > >  	/* Sync object to signal when the TFU job is done. */
> > >  	__u32 out_sync;
> > > +
> > > +	/* Number of extensions*/
> > > +	__u32 extension_count;
> > > +
> > > +	/* Pointer to an array of ioctl extensions*/
> > > +	__u64 extensions;
> > > +
> > > +	/* DRM_V3D_SUBMIT_* properties */
> > > +	__u32 flags;
> > 
> > A silly nit: maybe put flags before the extension fields above for
> > consistency with the CSD and CL submission commands.
> 
> hmm.. I arranged it that way for alignment reasons (afaiu), but I can
> (or should) include a _u32 pad right after out_sync to set these in
> the
> same sequence.

Ah, that's fine, my suggestion was just for style, let's keep it as is.

Iago