[PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

nicolas saenz julienne nsaenz at kernel.org
Thu Sep 30 15:40:36 UTC 2021


On Thu, 2021-09-23 at 20:50 +0200, Maxime Ripard wrote:
> Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot
> time"), during the initial setup of the driver we call into the VC4 HDMI
> controller hooks to make sure the controller is properly disabled.
> 
> However, we were never making sure that the device was properly powered
> while doing so. This never resulted in any (reported) issue in practice,
> but since the introduction of commit 4209f03fcb8e ("drm/vc4: hdmi: Warn
> if we access the controller while disabled") we get a loud complaint
> when we do that kind of access.
> 
> Let's make sure we have the HDMI controller properly powered while
> disabling it.
> 
> Fixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time")
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenz at kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenz at kernel.org>

Regards,
Nicolas



More information about the dri-devel mailing list