[PATCH 6/8] drm/display: Move HDCP helpers into display-helper module

[Javier Martinez Canillas]

On 3/22/22 20:27, Thomas Zimmermann wrote:
> Move DRM's HDCP helper library into the display/ subdirectory and add
> it to DRM's display helpers. Split the header file into core and helpers.
> Update all affected drivers. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

After fixing Jani's comment about the drm_hdcp_helper_helper.h typo:

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

[snip]

> diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/display/drm_hdcp_helper.c
> similarity index 99%
> rename from drivers/gpu/drm/drm_hdcp.c
> rename to drivers/gpu/drm/display/drm_hdcp_helper.c
> index ca9b8f697202..0ebdfe7fef8f 100644
> --- a/drivers/gpu/drm/drm_hdcp.c
> +++ b/drivers/gpu/drm/display/drm_hdcp_helper.c
> @@ -13,7 +13,7 @@
>  #include <linux/slab.h>
>  #include <linux/firmware.h>
>  
> -#include <drm/drm_hdcp.h>
> +#include <drm/display/drm_hdcp_helper.h>
>  #include <drm/drm_sysfs.h>
>  #include <drm/drm_print.h>
>  #include <drm/drm_device.h>
> @@ -21,7 +21,7 @@
>  #include <drm/drm_mode_object.h>
>  #include <drm/drm_connector.h>
>  
> -#include "drm_internal.h"
> +#include "../drm_internal.h"
>  

As far as I can tell drivers/gpu/drm/drm_hdcp.c doesn't use any of the symbols
declared in "drm_internal.h" and this inclusion could just be removed.

If you agree and add a preparatory patch in v2, feel free to also add my R-B.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat