[PATCH v2 5/7] drm: mxsfb: Factor out mxsfb_set_mode()

Marek Vasut marex at denx.de
Wed Apr 6 22:06:43 UTC 2022


On 4/6/22 21:47, Lucas Stach wrote:
> Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut:
>> Pull mode registers programming from mxsfb_enable_controller() into
>> dedicated function mxsfb_set_mode(). This is a clean up. No functional
>> change.
> 
> This one however looks like over-factorization to me. Why pull out a
> mode_set function out of a mode_set function?

The entire point of this series is to clean up the mxsfb and isolate 
lcdif (the original lcdif) from any of the common code. Then I can just 
replace those functions with lcdif mx8mp variant ones in the other lcdif 
driver, while keeping the common code in sync (until deduplication happens).


More information about the dri-devel mailing list