[PATCH v2 4/7] drm: mxsfb: Move mxsfb_get_fb_paddr() away from register IO functions

[Marek Vasut]

On 4/7/22 11:47, Lucas Stach wrote:
> Am Donnerstag, dem 07.04.2022 um 00:05 +0200 schrieb Marek Vasut:
>> On 4/6/22 21:45, Lucas Stach wrote:
>>> Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut:
>>>> Move mxsfb_get_fb_paddr() out of the way, away from register IO functions.
>>>> This is a clean up. No functional change.
>>>>
>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>> Cc: Alexander Stein <alexander.stein at ew.tq-group.com>
>>>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>>>> Cc: Lucas Stach <l.stach at pengutronix.de>
>>>> Cc: Peng Fan <peng.fan at nxp.com>
>>>> Cc: Robby Cai <robby.cai at nxp.com>
>>>> Cc: Sam Ravnborg <sam at ravnborg.org>
>>>> Cc: Stefan Agner <stefan at agner.ch>
>>>
>>> Hm, I don't see any real benefit, but I also fail to see why it
>>> shouldn't be done so:
>>
>> The entire point of this series is to clean up the mxsfb and isolate
>> lcdif (the original lcdif) from any of the common code.
> 
> Actually, just use drm_fb_cma_get_gem_addr() instead?

That function seems to add only extra code that is executed, but does 
not do away with the !fb check anyway. So, why ? (Also, seems unrelated 
to this patch)