[PATCH v2 1/2] drm/panel: lvds: Simplify mode parsing

Marek Vasut marex at denx.de
Wed Apr 13 04:03:07 UTC 2022


On 4/7/22 13:16, Laurent Pinchart wrote:
> Hi Marek,
> 
> Thank you for the patch.
> 
> On Fri, Apr 01, 2022 at 06:21:53PM +0200, Marek Vasut wrote:
>> The mode parsing is currently implemented in three steps:
>> of_get_display_timing() - DT panel-timing to struct display_timing
>> videomode_from_timing() - struct display_timing to struct videomode
>> drm_display_mode_from_videomode() - struct videomode to struct drm_display_mode
>>
>> Replace all that with simple of_get_drm_panel_display_mode() call,
>> which already populates struct drm_display_mode and then duplicate
>> that mode in panel_lvds_get_modes() each time, since the mode does
>> not change.
>>
>> Nice bonus is the bus_flags parsed by of_get_drm_panel_display_mode()
>> out of panel-timing DT node, which is used in subsequent patch to fix
>> handling of 'de-active' DT property.
>>
>> Tested-by: Christoph Niedermaier <cniedermaier at dh-electronics.com>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Christoph Niedermaier <cniedermaier at dh-electronics.com>
>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>> Cc: Dmitry Osipenko <digetx at gmail.com>
>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>> Cc: Robert Foss <robert.foss at linaro.org>
>> Cc: Sam Ravnborg <sam at ravnborg.org>
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> To: dri-devel at lists.freedesktop.org
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

If that's OK with everyone, I will apply those soon.


More information about the dri-devel mailing list