[PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Mon Apr 25 21:08:18 UTC 2022


On 25/04/2022 23:10, Stephen Boyd wrote:
> Quoting cgel.zte at gmail.com (2022-04-25 02:09:47)
>> From: Lv Ruyi <lv.ruyi at zte.com.cn>
>>
>> The irq_of_parse_and_map() function returns 0 on failure, and does not
>> return a negative value anyhow, so never enter this conditional branch.
>>
>> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
>> Reported-by: Zeal Robot <zealci at zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
>> ---
> 
> Question still stands why we can't use platform device APIs.

Let's do a separate pass and replace all of functions with platform 
device API.

> Reviewed-by: Stephen Boyd <swboyd at chromium.org>


-- 
With best wishes
Dmitry


More information about the dri-devel mailing list