[PATCH v3 4/5] fbdev: Rename pagelist to pagereflist for deferred I/O

Thomas Zimmermann tzimmermann at suse.de
Fri Apr 29 07:27:34 UTC 2022


Hi

Am 29.04.22 um 09:21 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 4/26/22 14:03, Thomas Zimmermann wrote:
>> Rename various instances of pagelist to pagereflist. The list now
>> stores pageref structures, so the new name is more appropriate.
>>
>> In their write-back helpers, several fbdev drivers refer to the
>> pageref list in struct fb_deferred_io instead of using the one
>> supplied as argument to the function. Convert them over to the
>> supplied one. It's the same instance, so no change of behavior
>> occurs.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Suggested-by: Sam Ravnborg <sam at ravnborg.org>
> 
> I thougt the convention was to have Suggested-by before your S-o-B.

I always thought that the convention was that the authors S-o-B goes 
first. But 'git log' indeed indicates otherwise. I will change this 
before merging the patch.

> 
> The patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> 

Thanks

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220429/8e0ffb4d/attachment.sig>


More information about the dri-devel mailing list