[PATCH] drm/msm: add missing include to msm_drv.c

Abhinav Kumar quic_abhinavk at quicinc.com
Sat Apr 30 15:00:12 UTC 2022


Change seems fine, with a couple of minor things below.

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

On 4/30/2022 3:48 AM, Dmitry Baryshkov wrote:
> Add explicit include of drm_bridge.h to the msm_drm.c to fix the

this should be msm_drv.c

> following warning:
> 
> drivers/gpu/drm/msm/msm_drv.c:236:17: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]
> 
> Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges")

How did the this commit compile without this?

> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
>   drivers/gpu/drm/msm/msm_drv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 4f3dce334553..4a3dda23e3e0 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -11,6 +11,7 @@
>   #include <linux/uaccess.h>
>   #include <uapi/linux/sched/types.h>
>   
> +#include <drm/drm_bridge.h>
>   #include <drm/drm_drv.h>
>   #include <drm/drm_file.h>
>   #include <drm/drm_ioctl.h>


More information about the dri-devel mailing list