[PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c

Rodrigo Siqueira Jordao Rodrigo.Siqueira at amd.com
Tue Aug 2 16:57:24 UTC 2022



On 2022-08-01 09:52, Imre Deak wrote:
> Fix compiler warnings like the following triggered by
> '-Wmissing-prototypes':
> 
>    CC [M]  drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for ‘amd_get_format_info’ [-Wmissing-prototypes]

I see "‘" around "amd_get_format_info"; I'm not sure if my email 
client adds that or if there is something wrong in the commit message.

With the commit message change:

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>

>   const struct drm_format_info *amd_get_format_info(const struct drm_mode_fb_cmd2 *cmd)
> 
> Fixes: 5d945cbcd4b1 ("drm/amd/display: Create a file dedicated to planes")
> Cc: Harry Wentland <Harry.Wentland at amd.com>
> Cc: Alan Liu <HaoPing.Liu at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 5eb5d31e591de..da3b086b0d6ef 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -33,6 +33,7 @@
>   #include "amdgpu.h"
>   #include "dal_asic_id.h"
>   #include "amdgpu_display.h"
> +#include "amdgpu_dm_plane.h"
>   #include "amdgpu_dm_trace.h"
>   #include "gc/gc_11_0_0_offset.h"
>   #include "gc/gc_11_0_0_sh_mask.h"



More information about the dri-devel mailing list