[PATCH v2,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

Nícolas F. R. A. Prado nfraprado at collabora.com
Mon Aug 22 13:23:50 UTC 2022


On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote:
[..]
> Hi Nícolas:
> 
> Thanks for your careful review.
> I will correct it in the next version:
> 1. Modify key nouns in the description;
> 2. Modify the label of jitao to Co-developed-by;

To be clear, you shouldn't change jitao's signed-off-by to a co-developed-by,
but add a co-developed-by. If you check the link I sent earlier [1], it should
be clear that you should have something like

Co-developed-by: Jitao Shi <jitao.shi at mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi at mediatek.com>
Signed-off-by: Xinlei Lee <xinlei.lee at mediatek.com>

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Thanks,
Nícolas

> 3. Macro definition address lowercase problem and function naming.
> 
> If there are no other questions, I will send out the second edition in
> the near future.
> 
> Best Regards!
> xinlei
> 


More information about the dri-devel mailing list